I figured you would say that ;-) Seeing how Soren (so that's 2 votes) is also fine with it, then let's just kick it to the crub and go ahead and include the patch. On Fri, 2008-06-13 at 12:44 -0500, Anthony Liguori wrote: > Jerone Young wrote: > > After getting some private emails on this patch. I felt that I needed to > > say that these patches probably should not go in. > > > > I agree with your sentiment, --disable-cpu-emulation is a terrible hack > that's is only going to make things difficult to merge with upstream. > > The proper solution is to implement a -kvm target type much like > -softmmu and -linux-user. > > So I think this patch series should go in. > > Regards, > > Anthony Liguori > > > There is some value in having a kvm only binary. So having the --disable > > cpu-emulation flag still has value. > > > > > > So best not to remove this honestly until everything completely merges > > with upstream qemu. > > > > On Tue, 2008-06-10 at 13:50 -0500, Jerone Young wrote: > > > >> These patches remove all traces of --disable-cpu-emulation configuration flag. > >> > >> Signed-off-by: Jerone Young <jyoung5@xxxxxxxxxx> > >> > >> 6 files changed, 2 insertions(+), 227 deletions(-) > >> qemu/Makefile.target | 6 -- > >> qemu/configure | 13 ----- > >> qemu/target-i386/fake-exec.c | 54 --------------------- > >> qemu/target-ia64/fake-exec.c | 44 ----------------- > >> qemu/target-ppc/fake-exec.c | 104 ------------------------------------------ > >> qemu/vl.c | 8 --- > >> -- > >> To unsubscribe from this list: send the line "unsubscribe kvm" in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > > > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html