Re: + kvm-ia64-dereference-of-null-pointer-in-set_pal_result.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/13/2010 12:11 AM, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
Subject: kvm/ia64: dereference of NULL pointer in set_pal_result()
From: Roel Kluin<roel.kluin@xxxxxxxxx>

Do not dereference a NULL pointer

diff -puN arch/ia64/kvm/kvm_fw.c~kvm-ia64-dereference-of-null-pointer-in-set_pal_result arch/ia64/kvm/kvm_fw.c
--- a/arch/ia64/kvm/kvm_fw.c~kvm-ia64-dereference-of-null-pointer-in-set_pal_result
+++ a/arch/ia64/kvm/kvm_fw.c
@@ -75,9 +75,11 @@ static void set_pal_result(struct kvm_vc
  	struct exit_ctl_data *p;

  	p = kvm_get_exit_data(vcpu);
-	if (p&&  p->exit_reason == EXIT_REASON_PAL_CALL) {
+	if (!p)
+		return;
+	if (p->exit_reason == EXIT_REASON_PAL_CALL) {
  		p->u.pal_data.ret = result;
-		return ;
+		return;
  	}
  	INIT_PAL_STATUS_UNIMPLEMENTED(p->u.pal_data.ret);
  }


kvm_get_exit_data() cannot return a NULL pointer.

Where did this come from?

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux KVM Devel]     [Linux Virtualization]     [Big List of Linux Books]     [Linux SCSI]     [Yosemite Forum]

  Powered by Linux