Re: [patch] fix qemu-kvm to build when gdbstub is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Avi Kivity wrote:
I agree, unless

- we want to make gdbstub support configurable (don't see any overwhelming reason for this, but maybe others do) - we want to merge ia64 kvm support upstream, and don't want to impose gdbstub support (though I'd recommend properly implementing gdbstub)

In any case, I'm okay with dropping the check upstream and applying the local fixup.


Here's a patch that fixes the #ifndef to make it the #ifdef as it was

I am quite fine with us trying to drop all the #ifdefs and introduce
noop wrappers for archs that do not provide the gdbstubs (ie. ia64), but
to start with we better just fix the #ifndef to make it behave like it
was originally intended.


Fix incorrect #ifndef for CONFIG_GETSTUB, which should have been an

Signed-off-by: Jes Sorensen <jes@xxxxxxx>

 vl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: qemu/vl.c
--- qemu.orig/vl.c
+++ qemu/vl.c
@@ -4350,7 +4350,7 @@
         if (cpu_can_run(env))
             ret = qemu_cpu_exec(env);
         if (ret == EXCP_DEBUG) {
             debug_requested = 1;

[Index of Archives]     [Linux KVM Devel]     [Linux Virtualization]     [Big List of Linux Books]     [Linux SCSI]     [Yosemite Forum]

  Powered by Linux