>>>>> "Avi" == Avi Kivity <avi@xxxxxxxxxx> writes: Avi> Zhang, Xiantao wrote: >>> qemu_get_ram_ptr() returns a pointer. Don't cast it to a >>> ram_addr_t, leave it a pointer. >>> >>> But why not use cpu_physical_memory_write() (or >>> cpu_physical_memory_write_rom())? It's much simpler and cleaner. >>> >> Good suggestion! I just followed the original logic. Updated the >> patch. Xiantao Avi> Thanks, applied. Hi, I am not crazy about this patch. You need to use cpy_physical_memory_rw() in the hob and nvram code too, not just in the ipf.c code. What about the flush_icache_range() call you removed - is it safe to just discard that? I was in the process of working through this myself, but I am not quite finished. If you don't mind waiting a couple hours, I should have something a fair bit simpler to solve the same problem. Biggest issue is the flush_icache_range() one. Cheers, Jes -- To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
