On Tue, Dec 02, 2008 at 03:01:20PM +0200, Avi Kivity wrote: > Daniel P. Berrange wrote: > >On Tue, Dec 02, 2008 at 10:25:49AM +0800, Zhang, Yang wrote: > > > >>This patch to save the nvram. It save the nvram by specify the arg of > >>-name.And the saved file named by the arg. If do not specify the arg, > >>it will not save the nvram > >> > > > >I think we might be better off having an explicit command line arg for > >nvram > >path rather than hardcoding the directory, because there may well be times > >where you want to have nvram saved, but don't want to specify -name, and > >vica-verca. > > > > -nvram foo.data > > > >could prepend a default directory of $localstatedir/lib/qemu/nvram, where > >$localstatedir is set from 'configure' script, or > > > > -nvram /some/path/foo.data > > > >would use the explicit path given. > > > > I prefer current directory if relative path is given. Since we > encourage running qemu as an unprivileged user, and we don't want a > world-writable directory, each user will have to provide a private > storage location. Fine by me - avoids needing to embed any path in QEMU code at all then Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
