Re: [PATCH 04/08]kvm: Split arch/x86/kvm/irq.c to two parts.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Zhang, Xiantao wrote:
From 720dab659e581adba3a7846db6d2f612ffcd83a0 Mon Sep 17 00:00:00 2001
From: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
Date: Mon, 6 Oct 2008 13:48:45 +0800
Subject: [PATCH] kvm: Split arch/x86/kvm/irq.c to two parts.

Moving irq ack notification logic as common, and make
it shared with ia64 side.


+/* This should be called with the kvm->lock mutex held */
+void kvm_set_irq(struct kvm *kvm, int irq, int level)
+{
+	/* Not possible to detect if the guest uses the PIC or the
+	 * IOAPIC.  So set the bit in both. The guest will ignore
+	 * writes to the unused one.
+	 */
+	kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level);
+#ifdef X86
+	kvm_pic_set_irq(pic_irqchip(kvm), irq, level);
+#endif
+}
+

This needs to be CONFIG_X86, not X86. As is, Windows doesn't even boot. Fixing it causes compile errors for missing declarations and pic_irqchip().

Please fix ASAP and test much more carefully. Meanwhile I am reverting the patchset.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux KVM Devel]     [Linux Virtualization]     [Big List of Linux Books]     [Linux SCSI]     [Yosemite Forum]

  Powered by Linux