Amit Shah wrote: > * On Friday 03 Oct 2008 13:02:05 Zhang, Xiantao wrote: >> Amit Shah wrote: >>> * On Monday 29 Sep 2008 10:56:29 Zhang, Xiantao wrote: >>>> From: Xiantao Zhang <xiantao.zhang@xxxxxxxxx> >>>> Date: Sat, 27 Sep 2008 10:59:36 +0800 >>>> Subject: [PATCH] kvm: Moving device_assignment logic to kvm_main.c >>>> >>>> To share with other archs, this patch moves device_assignment >>>> logic to common parts. Signed-off-by: Xiantao Zhang >>>> <xiantao.zhang@xxxxxxxxx> >>>> >>>> diff --git a/include/linux/kvm.h b/include/linux/kvm.h >>>> index 4269be1..9acf34a 100644 >>>> --- a/include/linux/kvm.h >>>> +++ b/include/linux/kvm.h >>>> @@ -383,7 +383,9 @@ struct kvm_trace_rec { >>>> #define KVM_CAP_MP_STATE 14 >>>> #define KVM_CAP_COALESCED_MMIO 15 >>>> #define KVM_CAP_SYNC_MMU 16 /* Changes to host mmap are reflected >>>> in guest */ +#ifdef CONFIG_X86 >>>> #define KVM_CAP_DEVICE_ASSIGNMENT 17 >>>> +#endif >>> >>> I didn't see this changed to also accomodate IA64 in the patchset. >> >> Since linux-ia64 DMAR is not ready in kvm.git, and it should be in >> linux-ia64.git. So it should be in kvm.git once Avi merged with > OK; Does Linus' tree currently have the necessary support? If Linus's tree has picked up it from linux-ia64, it should be ready. > Also, I think you'll have to redo the patch 1/8 after Weidong's mmio > patch got merged. Yes, if weidong's patch merged first, the patch should be regenerated :) >> upstream, so I didn't enable it for kvm/ia64 now. You know, S390 >> has no pci support, so if we put the code in kvm_mainc, we should >> use the macro to exclude other arch which doesn't need device >> assignments. If DMAR is ready for kvm.git, I will change this macro >> as following: #if defined(CONFIG_X86) || defined(CONFIG_IA64) >> #define KVM_CAP_DEVICE_ASSIGNMENT 17 >> #endif > > Yes, that's what I meant. -- To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html