Re: [PATCH]Export the symbol ia64_patch_imm64.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 09, 2008 at 01:11:33PM +0800, Zhang, Xiantao wrote:
> diff --git a/arch/ia64/kernel/ia64_ksyms.c
> b/arch/ia64/kernel/ia64_ksyms.c
> index 6da1f20..b872f54 100644
> --- a/arch/ia64/kernel/ia64_ksyms.c
> +++ b/arch/ia64/kernel/ia64_ksyms.c
> @@ -86,6 +86,9 @@ EXPORT_SYMBOL(ia64_save_scratch_fpregs);
>  #include <asm/unwind.h>
>  EXPORT_SYMBOL(unw_init_running);
>  
> +#include <asm/patch.h>
> +EXPORT_SYMBOL_GPL(ia64_patch_imm64);

This shouldn't be exported in ia64_ksyms.c, it should be exported from
arch/ia64/kernel/patch.c.  See Documentation/CodingStyle, chapter 6.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux KVM Devel]     [Linux Virtualization]     [Big List of Linux Books]     [Linux SCSI]     [Yosemite Forum]

  Powered by Linux