RE: [patch] fix zero extending for mmio ld1/2/4 emulation in KVM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jes Sorensen wrote:
> Matthew Chapman wrote:
>> Jes,
>> 
>> Glad you tracked it down.  Can I suggest rather than using memcpy, a
>> more efficient way might be something like...
>> 
>> #define ZERO_EXTEND(x,bits) ((x) & (~0UL >> (64-(bits))))
>> 
>> *dest = ZERO_EXTEND(p->u.ioreq.data, 8*s);
> 
> Much nicer indeed!
> 
> Here's a pretty version - Tony will you apply this one instead.
Hi, Jes
    Good catch!!   Since this is a key fix for 2.6.26, Avi or Tony may
help to push the fix into upstream.  :-)
Xiantao

--
To unsubscribe from this list: send the line "unsubscribe kvm-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux KVM Devel]     [Linux Virtualization]     [Big List of Linux Books]     [Linux SCSI]     [Yosemite Forum]

  Powered by Linux