I was writing a quick test when I noticed that arm's implementation of __virt_to_phys(), which ends up calling virt_to_pte_phys(), doesn't handle block mappings and returns a bogus value. When fixing that, I realized that lib/vmalloc confuses the return value for virt_to_pte_phys(), which is harmless, but still wrong. I also got confused about mmu_get_pte() and get_pte(), so I (hopefully) improved that by renaming mmu_get_pte() to follow_pte(). Tested on rockpro64: arm64, 4k and 64k pages, with qemu and kvmtool; arm, with qemu and kvmtool. And on an odroid-c4: arm64, 4k, 16k and 64k pages with qemu and kvmtool; arm, with qemu and kvmtool. Alexandru Elisei (3): lib/vmalloc: Treat virt_to_pte_phys() as returning a physical address arm/arm64: mmu: Teach virt_to_pte_phys() about block descriptors arm/arm64: mmu: Rename mmu_get_pte() -> follow_pte() lib/arm/asm/mmu-api.h | 2 +- lib/arm/mmu.c | 88 +++++++++++++++++++++++++------------------ lib/vmalloc.c | 4 +- 3 files changed, 55 insertions(+), 39 deletions(-) -- 2.37.0 _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
