On Thu, 22 Sep 2022 22:38:58 +0100, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On Thu, Sep 22, 2022 at 7:02 PM Marc Zyngier <maz@xxxxxxxxxx> wrote: > > To make sure that all the writes to the log marking the entries > > as being in need of reset are observed in order, use a > > smp_store_release() when updating the log entry flags. > > > > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> > > You also need a load-acquire on the load of gfn->flags in > dirty_gfn_is_dirtied. Otherwise reading cur->slot or cur->offset might > see a stale value. Ah, indeed. smp_wmb() is implemented as DMB ISHST, which only orders writes, and not loads against writes. Global barriers are just confusing. /me goes and repaint the stuff... M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
