On Fri, 15 Jul 2022 07:10:09 +0100, Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote: > > Hi all, > > This is v4 of the series adding support for nVHE hypervisor stacktraces; > and is based on arm64 for-next/stacktrace. > > Thanks all for your feedback on previous revisions. Mark Brown, I > appreciate your Reviewed-by on the v3, I have dropped the tags in this > new verision since I think the series has changed quite a bit. > > The previous versions were posted at: > v3: https://lore.kernel.org/r/20220607165105.639716-1-kaleshsingh@xxxxxxxxxx/ > v2: https://lore.kernel.org/r/20220502191222.4192768-1-kaleshsingh@xxxxxxxxxx/ > v1: https://lore.kernel.org/r/20220427184716.1949239-1-kaleshsingh@xxxxxxxxxx/ > > The main updates in this version are to address concerens from Marc on the > memory usage and reusing the common code by refactoring into a shared header. Overall, the series looks better. I've pointed out a few things that need changing, but my overall gripe is around the abuse the stacktrace/nvhe.h as a dumping ground. A lot of the code there could be pushed to handle_exit.c (or some other compilation unit). I've pushed an example of a 10 minutes refactor in my tree (kvm-arm64/nvhe-stacktrace), and I'm sure these are the lowest hanging fruits. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
