Re: [PATCH 04/18] KVM: arm64: Move FP state ownership from flag to a tristate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 03 Jun 2022 10:14:11 +0100,
Mark Brown <broonie@xxxxxxxxxx> wrote:
> 
> On Sat, May 28, 2022 at 12:38:14PM +0100, Marc Zyngier wrote:
> 
> > As it turns out, this isn't really a good match for flags, and
> > we'd be better off if this was a simpler tristate, each state
> > having a name that actually reflect the state:
> > 
> > - FP_STATE_CLEAN
> > - FP_STATE_HOST_DIRTY
> > - FP_STATE_GUEST_DIRTY
> 
> I had to think a bit more than I liked about the _DIRTY in the
> names of the host and guest flags, but that's really just
> bikeshedding and not a meaningful issue.

Another option was:

- FP_STATE_FREE
- FP_STATE_HOST_OWNED
- FP_STATE_GUEST_OWNED

I don't mind wither way.

> Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux