On Fri, Apr 29, 2022 at 5:47 AM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Wed, Apr 27, 2022 at 11:46:56AM -0700, Kalesh Singh wrote: > > > Recompile stack unwinding code for use with the nVHE hypervisor. This is > > a preparatory patch that will allow reusing most of the kernel unwinding > > logic in the nVHE hypervisor. > > This is substantially more than just the build change that the changelog > would seem to indicate... it would I think be clearer to split this up > further with the code changes separated out and explained a bit more. > It's not just recompling the code for nVHE, there's also refactoring to > split out changes that don't apply in nVHE hypervisor like all the task > related code which is needed but not mentioned in the changlog at all. > Possibly a patch or two for the code motion then a separate patch for > the ifdefs and build changes? Hi Mark, Thank you for reviewing. I agree - will split this into more incremental patches in the next version. Thanks, Kalesh > > I *think* the code is all fine but I'd need to go through it a few more > times to be sure I didn't miss anything. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
