On Thu, Mar 24, 2022 at 12:07:34PM +0800, Gavin Shan wrote: [...] > > > Yeah, I was sticky to the pattern of "KVM". However, I think it's good > > > to reuse the existing one. Lets use ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_2 > > > if you agree. Its first two characters are "VM" at least. > > > > Sounds fine to me. The only other nit I'd say is we should define a > > macro for it too, something like: > > > > #define KVM_SDEI_VENDOR ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_2 > > > > Agreed, and the macro will be put into arch/arm64/include/asm/kvm_sdei.h. > arch/arm64/include/uapi/asm/kvm_sdei_state.h isn't the right place because > the dependent macro ARM_SMCCC_VENDOR_HYP_UID_KVM_REG_2 isn't exposed by > ABI. The argument could definitely be made that our vendor ID should be promoted to UAPI. Even though linux is the only known user of our vendor-specific hypercalls, nothing is stopping other software from using them. Beyond that, these values should really never change anyway. It isn't a big deal if you add it to internal headers, either, as the only known consumer will be the kernel. -- Thanks, Oliver _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
