Re: [PATCH v5 00/22] Support SDEI Virtualization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Oliver,

On 3/23/22 2:13 AM, Oliver Upton wrote:
On Tue, Mar 22, 2022 at 04:06:48PM +0800, Gavin Shan wrote:
This series intends to virtualize Software Delegated Exception Interface
(SDEI), which is defined by DEN0054C (v1.1). It allows the hypervisor to
deliver NMI-alike SDEI event to guest and it's needed by Async PF to
deliver page-not-present notification from hypervisor to guest. The code
and the required qemu changes can be found from:

    https://developer.arm.com/documentation/den0054/c
    https://github.com/gwshan/linux    ("kvm/arm64_sdei")
    https://github.com/gwshan/qemu     ("kvm/arm64_sdei")

For the design and migration needs, please refer to the document in
PATCH[21/22] in this series. The series is organized as below:

   PATCH[01]    Introduces template for smccc_get_argx()
   PATCH[02]    Adds SDEI virtualization infrastructure
   PATCH[03-17] Supports various SDEI hypercalls and event handling
   PATCH[18-20] Adds ioctl commands to support migration and configuration
                and exports SDEI capability
   PATCH[21]    Adds SDEI document
   PATCH[22]    Adds SDEI selftest case

Testing
=======

[1] The selftest case included in this series works fine. The default SDEI
     event, whose number is zero, can be registered, enabled, raised. The
     SDEI event handler can be invoked.

     [host]# pwd
     /home/gavin/sandbox/linux.main/tools/testing/selftests/kvm
     [root@virtlab-arm01 kvm]# ./aarch64/sdei

         NR_VCPUS: 2    SDEI Event: 0x00000000

     --- VERSION
         Version:              1.1 (vendor: 0x4b564d)
     --- FEATURES
         Shared event slots:   0
         Private event slots:  0
         Relative mode:        No
     --- PRIVATE_RESET
     --- SHARED_RESET
     --- PE_UNMASK
     --- EVENT_GET_INFO
         Type:                 Private
         Priority:             Normal
         Signaled:             Yes
     --- EVENT_REGISTER
     --- EVENT_ENABLE
     --- EVENT_SIGNAL
         Handled:              Yes
         IRQ:                  No
         Status:               Registered-Enabled-Running
         PC/PSTATE:            000000000040232c 00000000600003c5
         Regs:                 0000000000000000 0000000000000000
                               0000000000000000 0000000000000000
     --- PE_MASK
     --- EVENT_DISABLE
     --- EVENT_UNREGISTER

         Result: OK

[2] There are additional patches in the following repositories to create
     procfs entries, allowing to inject SDEI event from host side. The
     SDEI client in the guest side registers the SDEI default event, whose
     number is zero. Also, the QEMU exports SDEI ACPI table and supports
     migration for SDEI.

     https://github.com/gwshan/linux    ("kvm/arm64_sdei")
     https://github.com/gwshan/qemu     ("kvm/arm64_sdei")

     [2.1] Start the guests and migrate the source VM to the destination
           VM.

     [host]# /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64       \
             -accel kvm -machine virt,gic-version=host                     \
             -cpu host -smp 6,sockets=2,cores=3,threads=1                  \
             -m 1024M,slots=16,maxmem=64G                                  \
                :                                                          \
             -kernel /home/gavin/sandbox/linux.guest/arch/arm64/boot/Image \
             -initrd /home/gavin/sandbox/images/rootfs.cpio.xz             \
             -append earlycon=pl011,mmio,0x9000000                         \
                :

     [host]# /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64       \
             -accel kvm -machine virt,gic-version=host                     \
             -cpu host -smp 6,sockets=2,cores=3,threads=1                  \
             -m 1024M,slots=16,maxmem=64G                                  \
                :                                                          \
             -kernel /home/gavin/sandbox/linux.guest/arch/arm64/boot/Image \
             -initrd /home/gavin/sandbox/images/rootfs.cpio.xz             \
             -append earlycon=pl011,mmio,0x9000000                         \
             -incoming tcp:0:4444                                          \
                :

     [2.2] Check kernel log on the source VM. The SDEI service is enabled
           and the default SDEI event (0x0) is enabled.

      [guest-src]# dmesg | grep -i sdei
      ACPI: SDEI 0x000000005BC80000 000024 \
                 (v00 BOCHS  BXPC     00000001 BXPC 00000001)
      sdei: SDEIv1.1 (0x4b564d) detected in firmware.
      SDEI TEST: Version 1.1, Vendor 0x4b564d
      sdei_init: SDEI event (0x0) registered
      sdei_init: SDEI event (0x0) enabled

(qemu) migrate -d tcp:localhost:4444

     [2.3] Migrate the source VM to the destination VM. Inject SDEI event
           to the destination VM. The event is raised and handled.

     (qemu) migrate -d tcp:localhost:4444

     [host]# echo 0 > /proc/kvm/kvm-5360/vcpu-1

     [guest-dst]#
     =========== SDEI Event (CPU#1) ===========
     Event: 0000000000000000  Parameter: 00000000dabfdabf
     PC: ffff800008cbb554  PSTATE: 00000000604000c5  SP: ffff800009c7bde0
     Regs:    00000000000016ee ffff00001ffd2e28 00000000000016ed 0000000000000001
              ffff800016c28000 0000000000000000 0000000000000000 0000000000000000
              0000000000000000 0000000000000000 0000000000000000 0000000000000000
              0000000000000000 0000000000000000 0000000000000000 0000000000000000
              0000000000000000 0000000000000000 0000000000000000 ffff800009399008
              ffff8000097d9af0 ffff8000097d99f8 ffff8000093a8db8 ffff8000097d9b18
              0000000000000000 0000000000000000 ffff000000339d00 0000000000000000
              0000000000000000 ffff800009c7bde0 ffff800008cbb5c4
     Context: 00000000000016ee ffff00001ffd2e28 00000000000016ed 0000000000000001
              ffff800016c28000 03ffffffffffffff 000000024325db59 ffff8000097de190
              ffff00000033a790 ffff800008cbb814 0000000000000a30 0000000000000000

Changelog
=========
v5:

Next time can you include a link to the cover letter of the previous
patch set? It is extremely helpful for understanding the progress to
date and allows reviewers to see prior feedback.


Yep, I will provide the link to the cover letter of the previous version.
I'm amending it this time:

    https://lore.kernel.org/all/20210815001352.81927-3-gshan@xxxxxxxxxx/

Besides, I don't know what happened to my "git send-email". Some of the
recipients are skipped even I have put them into the cc list. Lets amend
it again to avoid resending the series.

Thanks,
Gavin


_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux