Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-02-25 12:29, Will Deacon wrote:
On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
From: kernel test robot <lkp@xxxxxxxxx>

arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest")
CC: Will Deacon <will@xxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   d4a0ae62a277377de396850ed4b709b6bd9b7326
commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest
:::::: branch date: 18 hours ago
:::::: commit date: 3 days ago

 arch/arm64/kvm/psci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/arm64/kvm/psci.c
+++ b/arch/arm64/kvm/psci.c
@@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
 				ret = 0;
 			}
 			break;
-		};
+		}

Acked-by: Will Deacon <will@xxxxxxxxxx>

but I really don't think this needs a Fixes: tag

The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...

If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.

[1] https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@xxxxxxxxxx
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux