Hi,
On Thu, Feb 17, 2022 at 03:43:15PM +0000, Alexandru Elisei wrote:
> Hi,
>
> Some general comments while I familiarize myself with the stolen time spec.
>
> On Thu, Feb 17, 2022 at 03:08:53PM +0000, Sebastian Ene wrote:
[..]
> >
> > + /* Populate the vcpu structure. */
> > + vcpu->kvm = kvm;
> > + vcpu->cpu_id = cpu_id;
> > + vcpu->cpu_type = vcpu_init.target;
> > + vcpu->cpu_compatible = target->compatible;
> > + vcpu->is_running = true;
> > +
> > if (err || target->init(vcpu))
> > die("Unable to initialise vcpu");
> >
> > @@ -125,13 +132,6 @@ struct kvm_cpu *kvm_cpu__arch_init(struct kvm *kvm, unsigned long cpu_id)
> > vcpu->ring = (void *)vcpu->kvm_run +
> > (coalesced_offset * PAGE_SIZE);
> >
> > - /* Populate the vcpu structure. */
> > - vcpu->kvm = kvm;
> > - vcpu->cpu_id = cpu_id;
> > - vcpu->cpu_type = vcpu_init.target;
> > - vcpu->cpu_compatible = target->compatible;
> > - vcpu->is_running = true;
> > -
>
> Why this change?
Got it know, it's needed for target->init, which is actually arm_cpu__vcpu_init.
Weird that it wasn't that way in the first place, but that's because of the
awkwardness of generating the fdt nodes for the gic/timer/pmu.
Thanks,
Alex
>
> Thanks,
> Alex
>
> > if (kvm_cpu__configure_features(vcpu))
> > die("Unable to configure requested vcpu features");
> >
> > --
> > 2.35.1.265.g69c8d7142f-goog
> >
> _______________________________________________
> kvmarm mailing list
> kvmarm@xxxxxxxxxxxxxxxxxxxxx
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
