On 1/26/22 1:13 PM, Mark Brown wrote:
On Wed, Jan 26, 2022 at 01:03:44PM -0700, Shuah Khan wrote:
On 1/26/22 12:52 PM, Mark Brown wrote:
If the function fails for any reason other than the system not
supporting vgic-v3 it will abort rather than return.
Hmm. vgic_v3_setup() return gic_fd looks like and the interface says
Return: GIC file-descriptor or negative error code upon failure
Yes, but in reality the only return other than a valid file descriptor
is just -1 rather than a useful error code.
The interface document gives the impression that it will return
error - Oh well. In which case, no point in printing that. Agree.
I don't follow the abort part.
All the TEST_ASSERTS() in the code (including those in the functions
called) are calls to test_assert() in assert.c which if the test
asserted isn't true will print some diagnostics and call exit(), the
general idiom is to give up immediately on error.
Ah right. Makes sense.
thanks,
-- Shuah
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
