On Tue, Dec 14, 2021 at 02:48:30PM +0000, Andrew Walbran wrote: > On Wed, 1 Dec 2021 at 17:04, 'Quentin Perret' via kernel-team > <kernel-team@xxxxxxxxxxx> wrote: > > > > From: Will Deacon <will@xxxxxxxxxx> > > > > In preparation for adding additional locked sections for manipulating > > page-tables at EL2, introduce some simple wrappers around the host and > > hypervisor locks so that it's a bit easier to read and bit more difficult > > to take the wrong lock (or even take them in the wrong order). > Looks good, but how does this help prevent taking locks in the wrong order? I just found that I would easily forget what exactly was protected by "pkvm_pgd_lock" and so relating that back to "take host before hyp" was error-prone. Having helpers with "host" and "hyp" in the name helps me with that, at least. Will _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
