On Thu, 15 Apr 2021 14:17:25 +0100, Alexandru Elisei wrote: > pmu__generate_fdt_nodes() checks if the host has support for PMU in a guest > and prints a warning if that's not the case. However, this check is too > late because the function is called after the VCPU has been created, and > VCPU creation fails if KVM_CAP_ARM_PMU_V3 is not available with a rather > unhelpful error: > > $ ./vm run -c1 -m64 -f selftest.flat --pmu > # lkvm run --firmware selftest.flat -m 64 -c 1 --name guest-1039 > Info: Placing fdt at 0x80200000 - 0x80210000 > Fatal: Unable to initialise vcpu > > [...] Applied to kvmtool (master), thanks! [1/1] arm: Fail early if KVM_CAP_ARM_PMU_V3 is not supported https://git.kernel.org/will/kvmtool/c/415f92c33a22 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm