Hi Andrew, Thanks for the patch. On Thu, Mar 18, 2021 at 02:33:07PM +0000, Andrew Scull wrote: > report_bug() will return early if it cannot find a bug corresponding to > the provided address. The subsequent test for the bug will always be > true so remove it. > > Fixes: 1b4cfe3c0a30d ("lib/bug.c: exclude non-BUG/WARN exceptions from report_bug()") This is purely cosmetic, so I'm not sure this warrants a fixes tag (i.e. I wouldn't expect this change to be backported). > Signed-off-by: Andrew Scull <ascull@xxxxxxxxxx> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > Cc: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx> > Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > --- > lib/bug.c | 33 +++++++++++++++------------------ > 1 file changed, 15 insertions(+), 18 deletions(-) But the change looks good: Acked-by: Will Deacon <will@xxxxxxxxxx> Will _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm