Hi Gavin, This function is only used by mmu.c in the first commit c64735554c0a, so please feel free to add: Reviewed-by: Keqian Zhu <zhukeqian1@xxxxxxxxxx> Thanks, Keqian On 2021/3/15 12:18, Gavin Shan wrote: > We needn't expose the function as it's only used by mmu.c. > > Signed-off-by: Gavin Shan <gshan@xxxxxxxxxx> > --- > arch/arm64/include/asm/kvm_host.h | 1 - > arch/arm64/kvm/mmu.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 3d10e6527f7d..688f2df1957b 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -632,7 +632,6 @@ void kvm_arm_resume_guest(struct kvm *kvm); > }) > > void force_vm_exit(const cpumask_t *mask); > -void kvm_mmu_wp_memory_region(struct kvm *kvm, int slot); > > int handle_exit(struct kvm_vcpu *vcpu, int exception_index); > void handle_exit_early(struct kvm_vcpu *vcpu, int exception_index); > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 77cb2d28f2a4..84e70f953de6 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -555,7 +555,7 @@ static void stage2_wp_range(struct kvm_s2_mmu *mmu, phys_addr_t addr, phys_addr_ > * Acquires kvm_mmu_lock. Called with kvm->slots_lock mutex acquired, > * serializing operations for VM memory regions. > */ > -void kvm_mmu_wp_memory_region(struct kvm *kvm, int slot) > +static void kvm_mmu_wp_memory_region(struct kvm *kvm, int slot) > { > struct kvm_memslots *slots = kvm_memslots(kvm); > struct kvm_memory_slot *memslot = id_to_memslot(slots, slot); > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm