On Tue, 23 Feb 2021 12:34:22 +0000, Andrew Scull <ascull@xxxxxxxxxx> wrote: > > On Tue, Feb 23, 2021 at 11:29:54AM +0000, Marc Zyngier wrote: [...] > > Would it be worth making it a helper that lives there? Something > > like > > > > struct bug_entry *bug_get_entry(unsigned long pc, char **file, > > unsigned int *line); > > > > that hides the #ifdefery and the fund_bug() call away? The > > disable_trace_on_warning() call isn't a problem, as we're about to die > > anyway. > > Yeah, that'd make a lot of sense. Please protect me from the wrath of > the community when I touch the common code.. The community should be pleased if you gifted it with a piece of reusable code instead of some less palatable copy-paste! :-) M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
