On 05/11/2020 17:15, kernel test robot wrote: > Hi Andre, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v5.10-rc2 next-20201105] > [cannot apply to arm64/for-next/core kvmarm/next arm-perf/for-next/perf] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Andre-Przywara/ARM-arm64-Add-SMCCC-TRNG-entropy-service/20201105-205934 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4ef8451b332662d004df269d4cdeb7d9f31419b5 > config: arm-randconfig-s031-20201105 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-76-gf680124b-dirty > # https://github.com/0day-ci/linux/commit/1f0c18ec0b7aa0a67d7cdea2b1beb5e7b38c5f4b > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Andre-Przywara/ARM-arm64-Add-SMCCC-TRNG-entropy-service/20201105-205934 > git checkout 1f0c18ec0b7aa0a67d7cdea2b1beb5e7b38c5f4b > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > arm-linux-gnueabi-ld: drivers/char/random.o: in function `arch_get_random_seed_long': >>> arch/arm/include/asm/archrandom.h:48: undefined reference to `arm_smccc_1_1_get_conduit' >>> arm-linux-gnueabi-ld: arch/arm/include/asm/archrandom.h:48: undefined reference to `smccc_trng_available' Found it, we should use "depends on HAVE_ARM_SMCCC_DISCOVERY" instead of HAVE_ARM_SMCCC, because only the former guarantees the build of smccc.c. Will fix it in the next version, (given we keep this arch random part). Thanks, Andre > > vim +48 arch/arm/include/asm/archrandom.h > > 42 > 43 static inline bool __must_check arch_get_random_seed_long(unsigned long *v) > 44 { > 45 struct arm_smccc_res res; > 46 > 47 if (smccc_trng_available) { > > 48 arm_smccc_1_1_invoke(ARM_SMCCC_TRNG_RND32, 8 * sizeof(*v), &res); > 49 > 50 if (res.a0 != 0) > 51 return false; > 52 > 53 *v = res.a3; > 54 return true; > 55 } > 56 > 57 return false; > 58 } > 59 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
