Re: [PATCH 5/6] drivers/acpi: Import ACPI APF table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gavin,

On 18/08/2020 02:13, Gavin Shan wrote:
> This defines the struct for ACPI APF table. The information included
> in this table will be used by guest kernel to retrieve SDEI event
> number, PPI number and its triggering properties:
> 
>    * @sdei_event: number of SDEI event used for page-not-present
>    * @interrupt:  PPI used for page-ready
>    * @interrupt_flags: PPI's mode and polarity
> 
> Signed-off-by: Gavin Shan <gshan@xxxxxxxxxx>
> ---
>  include/acpi/actbl2.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)


Whoa! This is not how changes to ACPI work!

We have to work out what is needed, then the standard has to be updated, then the upstream
acpica project, then these files get synced back across from the 'upstream' acpica project...

If you need an ACPI table, we need something for DT too. I don't think a well designed
paravirt interface shouldn't need this. Wasn't that the whole point of the KVM "vendor
specific" services?!

The cover-letter message talks of shared memory, which this doesn't describe.

Ideally this stuff would be discovered via SMCCC, or a (readonly?) page of that shared
memory. That way its the same regardless of ACPI or DT.


Thanks,

James
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux