Hi Andrew, On Monday 03 Aug 2020 at 10:17:56 (+0200), Andrew Jones wrote: > On Thu, Jul 30, 2020 at 04:33:46PM +0100, Will Deacon wrote: > > In terms of testing, I've done the usual Debian installer type things, but > > Quentin has also written targetted guest code [1] which we used to > > exercise dirty logging page-table collapse and coalescing. > ... > > [1] https://android-kvm.googlesource.com/misc/+/refs/heads/qperret/pgtable-test > > Hi Quentin, > > Any reason you didn't look into extending > > tools/testing/selftests/kvm/dirty_log_test > > and, if necessary, the AArch64 KVM selftests framework? I did run this particular test, but it didn't seem to exercise the code paths I wanted at the time, so I went with a custom-made implementation only to get this patch series out of the door as quickly as possible. But I have no plan to maintain / push this further, and we should definitely be looking at extending the selftest instead to cover this use-case. I'll try to get to it at some point but there are a few things I need to finish off first :) I hope that helps! Thanks, Quentin _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
