Hey Marc, > > - .popsection > > I'd be tempted to leave the .popsection in place, if only for symmetry with > the initial .pushsection. I removed it because other .S files don't pop either. It must have been added here purely for the smccc workaround code. Happy to add it back if you prefer, but the pushsection is removed later in the series, so this would disappear as well. > > + .pushsection .rodata > > + .global __smccc_workaround_1_smc > > +__smccc_workaround_1_smc: > > You probably want to replace this with SYM_DATA_START (and SYM_DATA_END at > the end). Done Thanks for reviewing, David _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
