Hi Zenghui,
On 3/30/20 10:30 AM, Zenghui Yu wrote:
> Hi Eric,
>
> On 2020/3/20 17:24, Eric Auger wrote:
>> +static void its_cmd_queue_init(void)
>> +{
>> + unsigned long order = get_order(SZ_64K >> PAGE_SHIFT);
>> + u64 cbaser;
>> +
>> + its_data.cmd_base = (void *)virt_to_phys(alloc_pages(order));
>
> Shouldn't the cmd_base (and the cmd_write) be set as a GVA?
yes it should
>
> Otherwise I think we will end-up with memory corruption when writing
> the command queue. But it seems that everything just works fine ...
> So I'm really confused here :-/
I was told by Paolo that the VA/PA memory map is flat in kvmunit test.
>
>> +
>> + cbaser = ((u64)its_data.cmd_base | (SZ_64K / SZ_4K - 1) |
>> GITS_CBASER_VALID);
>> +
>> + writeq(cbaser, its_data.base + GITS_CBASER);
>> +
>> + its_data.cmd_write = its_data.cmd_base;
>> + writeq(0, its_data.base + GITS_CWRITER);
>> +}
>
> Otherwise this looks good,
> Reviewed-by: Zenghui Yu <yuzenghui@xxxxxxxxxx>
Thanks!
Eric
>
>
> Thanks
>
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
