On Fri, Feb 21, 2020 at 12:55:16PM +0000, Marc Zyngier wrote: > Hi James, > > On 2020-02-20 16:58, James Morse wrote: > > Hello! > > > > It turns out KVM relies on the inline hint being honoured by the > > compiler > > in quite a few more places than expected. Something about the Shadow > > Call > > Stack support[0] causes the compiler to avoid inline-ing and to place > > these functions outside the __hyp_text. This ruins KVM's day. > > > > Add the simon-says __always_inline annotation to all the static > > inlines that KVM calls from HYP code. > > > > This series based on v5.6-rc2. > > Many thanks for going through all this. > > I'm happy to take it if Catalin or Will ack the arm64 patches. > It case we decide to go the other way around: > > Acked-by: Marc Zyngier <maz@xxxxxxxxxx> > > One thing I'd like to look into though is a compile-time check that > nothing in the hyp_text section has a reference to a non-hyp_text > symbol. > > We already have checks around non-init symbols pointing to init symbols, > and I was wondering if we could reuse this for fun and profit... Hi Marc, I recall that you've suggested that before, and I even tried it around that time [*]. I wasn't happy enough with it to post a proper patch though. [*] https://lists.cs.columbia.edu/pipermail/kvmarm/2018-May/031629.html Thanks, drew > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... > _______________________________________________ > kvmarm mailing list > kvmarm@xxxxxxxxxxxxxxxxxxxxx > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
