On Fri, Dec 20, 2019 at 03:36:47PM +0000, Marc Zyngier wrote:
> On 2019-12-20 15:05, Mark Rutland wrote:
> > +static inline unsigned long host_spsr_to_spsr32(unsigned long spsr)
> > +{
> > + const unsigned long overlap = BIT(24) | BIT(21);
> > + unsigned long dit = !!(spsr & PSR_AA32_DIT_BIT);
> > +
> > + spsr &= overlap;
>
> Are you sure this is what you want to do? This doesn't leave
> that many bits set in SPSR... :-/
Oh, whoops. :(
> Apart from what I believe is a missing ~ above, this looks good.
I've added the missing '~' and pushed out the updated branch.
Thanks,
Mark.
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
