On 12/1/19 12:20 PM, Marc Zyngier wrote: > + /* Check for an EL2 trap due to HSTR_EL2. We expect EL0 accesses > + * to sysregs non accessible at EL0 to have UNDEF-ed already. > + */ We're enforcing /* * Multi-line comment */ for qemu now; checkpatch should be reporting on that. > + if (!env->aarch64 && arm_current_el(env) < 2 && ri->cp == 15 && > + (arm_hcr_el2_eff(env) & (HCR_E2H | HCR_TGE)) != (HCR_E2H | HCR_TGE)) { Use is_a64(env) not env->aarch64 directly. Otherwise, Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> r~ _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm