On Tue, Jun 18, 2019 at 12:11 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > @@ -236,7 +236,8 @@ static int unwind_pop_register(struct unwind_ctrl_block *ctrl, > if (*vsp >= (unsigned long *)ctrl->sp_high) > return -URC_FAILURE; > > - ctrl->vrs[reg] = *(*vsp)++; > + ctrl->vrs[reg] = READ_ONCE_NOCHECK(*(*vsp)); > + (*vsp)++; I would probably even put in a comment here so it is clear why we do this. Passers-by may not know that READ_ONCE_NOCHECK() is even related to KASan. Other than that, Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
