Re: [PATCH RFC 11/14] arm64: Move the ASID allocator code in a separate file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guo,

On 19/06/2019 12:51, Guo Ren wrote:
On Wed, Jun 19, 2019 at 4:54 PM Julien Grall <julien.grall@xxxxxxx> wrote:



On 6/19/19 9:07 AM, Guo Ren wrote:
Hi Julien,

Hi,


You forgot CCing C-SKY folks :P

I wasn't aware you could be interested :).


Move arm asid allocator code in a generic one is a agood idea, I've
made a patchset for C-SKY and test is on processing, See:
https://lore.kernel.org/linux-csky/1560930553-26502-1-git-send-email-guoren@xxxxxxxxxx/

If you plan to seperate it into generic one, I could co-work with you.

Was the ASID allocator work out of box on C-Sky?
Almost done, but one question:
arm64 remove the code in switch_mm:
   cpumask_clear_cpu(cpu, mm_cpumask(prev));
   cpumask_set_cpu(cpu, mm_cpumask(next));



Why? Although arm64 cache operations could affect all harts with CTC
method of interconnect, I think we should
keep these code for primitive integrity in linux. Because cpu_bitmap
is in mm_struct instead of mm->context.

I will let Will answer to this.

[...]

If so, I can easily move the code in a generic place (maybe lib/asid.c).
I think it's OK.

Will emits concern to move the code in lib. So I will stick with what I currently have.

Cheers,

--
Julien Grall
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux