On 28/03/2019 16:48, Dave Martin wrote: > On Thu, Mar 28, 2019 at 02:29:23PM +0000, Julien Thierry wrote: >> >> >> On 28/03/2019 12:27, Dave Martin wrote: >>> On Wed, Mar 27, 2019 at 03:21:02PM +0000, Julien Thierry wrote: >>>> >>>> >>>> On 27/03/2019 10:33, Dave Martin wrote: > > [...] > >>>>> return slices; >>>>> } >>>>> >>>>> This may be clearer, but felt a bit like overkill... >>>>> >>>>> Thoughts? >>>> >>>> Seems a bit overkill yes... I was more thinking of a define and the >>>> person in charge of adding the slice support would just need to look for >>>> references to that define to know (some of) the places that would need >>>> rework/review. >>>> >>>> So, unless someone else thinks it's good to introduce it right now you >>>> can ignore that. >>> >>> OK, how about the following? This keeps things minimal, but should help >>> future maintainers know that something may need updating here in the >>> future. >>> >> >> Yes, I think this looks good. > > OK, are you happy for me to keep your Reviewed-by with that change? > Yes, please do! Thanks, -- Julien Thierry _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
