On Wed, Feb 20, 2019 at 03:23:50PM +0000, Mark Rutland wrote:
> On Mon, Feb 18, 2019 at 07:52:18PM +0000, Dave Martin wrote:
> > kvm_host.h uses DECLARE_BITMAP() to declare the features member of
> > struct vcpu_arch, but the corresponding #include for this is
> > missing.
> >
> > This patch adds a suitable #include for <linux/bitmap.h>. Although
> > the header builds without it today, this should help to avoid
> > future surprises.
> >
> > Signed-off-by: Dave Martin <Dave.Martin@xxxxxxx>
> > Reviewed-by: Alex Bennée <alex.bennee@xxxxxxxxxx>
> > ---
> > arch/arm64/include/asm/kvm_host.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> > index 7732d0b..84056a4 100644
> > --- a/arch/arm64/include/asm/kvm_host.h
> > +++ b/arch/arm64/include/asm/kvm_host.h
> > @@ -22,6 +22,7 @@
> > #ifndef __ARM64_KVM_HOST_H__
> > #define __ARM64_KVM_HOST_H__
> >
> > +#include <linux/bitmap.h>
> > #include <linux/types.h>
> > #include <linux/kvm_types.h>
> > #include <asm/cpufeature.h>
>
> From a quick scan of the file, we're also missing:
>
> #include <asm/barrier.h>
[...]
> #include <linux/jump_label.h>
> #include <linux/percpu.h>
Done for those three.
> #include <linux/thread_info.h>
Since commit e6b673b741ea ("KVM: arm64: Optimise FPSIMD handling to
reduce guest/host thrashing", we do have <asm/thread_info.h>.
Since this header is not generic, this seems reasonable. Is there
something from <linux/thread_info.h> used here that I'm missing?
Cheers
---Dave
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
