On Fri, Feb 22, 2019 at 04:23:23PM +0800, Leo Yan wrote: > Use macro for ID_AA64MMFR1_EL1.VH bits shift instead of 8 directly. > > Signed-off-by: Leo Yan <leo.yan at linaro.org> It's always nice to get rid of magic numbers, and this is correct AFAICT. FWIW: Reviewed-by: Mark Rutland <mark.rutland at arm.com> Mark. > --- > arch/arm64/kernel/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index 4471f570a295..3ac377e9fd28 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -490,7 +490,7 @@ ENTRY(el2_setup) > * kernel is intended to run at EL2. > */ > mrs x2, id_aa64mmfr1_el1 > - ubfx x2, x2, #8, #4 > + ubfx x2, x2, #ID_AA64MMFR1_VHE_SHIFT, #4 > #else > mov x2, xzr > #endif > -- > 2.17.1 >
