Re: [kvm-unit-tests PATCH v2 2/5] configure: arm/arm64: Add --vmm option with no effect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 01, 2019 at 11:16:38AM +0000, Alexandru Elisei wrote:
> Add configuration option --vmm to specify the virtual machine manager.
> Valid choices are 'qemu' and 'kvmtool', the default being 'qemu'. This
> option is only available for the arm and arm64 architectures and does
> nothing for now.
> 
> Signed-off-by: Alexandru Elisei <alexandru.elisei@xxxxxxx>
> ---
>  configure | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/configure b/configure
> index 44708b026422..0786e1604dba 100755
> --- a/configure
> +++ b/configure
> @@ -16,6 +16,7 @@ endian=""
>  pretty_print_stacks=yes
>  environ_default=yes
>  u32_long=
> +vmm="qemu"
>  
>  usage() {
>      cat <<-EOF
> @@ -24,6 +25,8 @@ usage() {
>  	Options include:
>  	    --arch=ARCH            architecture to compile for ($arch)
>  	    --processor=PROCESSOR  processor to compile for ($arch)
> +	    --vmm=VMM              virtual machine monitor to compile for (qemu
> +	                           or kvmtool, default is qemu) (arm/arm64 only)
>  	    --cross-prefix=PREFIX  cross compiler prefix
>  	    --cc=CC		   c compiler to use ($cc)
>  	    --cxx=CXX		   c++ compiler to use ($cxx)
> @@ -56,6 +59,9 @@ while [[ "$1" = -* ]]; do
>          --processor)
>  	    processor="$arg"
>  	    ;;
> +	--vmm)
> +	    vmm="$arg"
> +	    ;;
>  	--cross-prefix)
>  	    cross_prefix="$arg"
>  	    ;;
> @@ -108,6 +114,10 @@ if [ "$arch" = "i386" ] || [ "$arch" = "x86_64" ]; then
>      testdir=x86
>  elif [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
>      testdir=arm
> +    if [ "$vmm" != "qemu" ] && [ "$vmm" != "kvmtool" ]; then
> +        echo '--vmm must be one of "qemu" or "kvmtool"!'

nit: I'd drop the '!'

> +        usage
> +    fi
>  elif [ "$arch" = "ppc64" ]; then
>      testdir=powerpc
>      firmware="$testdir/boot_rom.bin"
> -- 
> 2.17.0
>
 
Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx>
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux