Re: [RFC PATCH 1/5] KVM: arm64: Remove pgd_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steve

On 08/13/2018 05:04 PM, Steven Price wrote:
The lock has never been used and the page tables are protected by
mmu_lock in struct kvm.

Signed-off-by: Steven Price <steven.price@xxxxxxx>
CC: Marc Zyngier <marc.zyngier@xxxxxxx>
CC: Christoffer Dall <christoffer.dall@xxxxxxx>

  arch/arm64/include/asm/kvm_host.h | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
index fe8777b12f86..8150a7f8a50f 100644
--- a/arch/arm64/include/asm/kvm_host.h
+++ b/arch/arm64/include/asm/kvm_host.h
@@ -61,8 +61,7 @@ struct kvm_arch {
  	u64    vmid_gen;
  	u32    vmid;
- /* 1-level 2nd stage table and lock */
-	spinlock_t pgd_lock;
+	/* 1-level 2nd stage table, protected by kvm->mmu_lock */
  	pgd_t *pgd;
/* VTTBR value associated with above pgd and vmid */


I have a patch which already does this, though not a dedicated patch [1] in the dynamic IPA series. As such I am fine with this patch being
merged if it gets there first, as we are still working out the userspace
API for dynamic IPA.

FWIW,

Reviewed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>



[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/591778.html
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux