On 2017/10/28 2:28, Marc Zyngier wrote: >> kvm_vcpu_trap_get_fault_type() will clear the low two bits to zero. So >> I use FSC_SEA_TTW represent "Synchronous external abort on translation >> table walk" > I understand that, and I certainly not keen on adding another "fault > type" for this. Ok, thanks. > >> As we can see the Translation fault type "FSC_FAULT", which does not >> define the "FSC_FAULT0" "FSC_FAULT1" "FSC_FAULT2" "FSC_FAULT3". >> Because the fault type " FSC_FAULT " include the four cases. > Indeed, and I'm still not convinced this is the best thing we have in > the code. Ok, thanks. > >> static inline u8 kvm_vcpu_trap_get_fault(const struct kvm_vcpu *vcpu) >> { >> return kvm_vcpu_get_hsr(vcpu) & 0x3f; >> } > Here you go. This should give you a pretty good idea of how to provide a > proper fix. OK, got it, thanks > > Thanks, _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm