On Tue, 17 Jan 2017, Marc Zyngier wrote: > +static int its_vpe_set_vcpu_affinity(struct irq_data *d, void *vcpu_info) > +{ > + struct its_vpe *vpe = irq_data_get_irq_chip_data(d); > + struct its_cmd_info *info = vcpu_info; > + u64 val; > + > + switch (info->cmd_type) { > + case SCHEDULE_VPE: > + { > + void * __iomem vlpi_base = gic_data_rdist_vlpi_base(); Moving the vlpi_base line on top of the fucntion spares you lines and brackets. No point in having the same thing twice Thanks, tglx _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm