Hi Christoffer,
In the document,
The mpidr field is used to specify which
redistributor is accessed. The mpidr is ignored for the distributor.
We still rely on MPIDR for KVM_DEV_ARM_VGIC_GRP_DIST_REGS to fetch
vcpu info. So don't we need to remove this restriction?.
Or force to use vcpu[0]?
Regards
Vijay
On Sat, Jan 21, 2017 at 1:27 AM, Christoffer Dall
<christoffer.dall@xxxxxxxxxx> wrote:
> On Fri, Dec 16, 2016 at 01:18:09PM +0100, Auger Eric wrote:
>> Hi Vijaya,
>>
>> On 01/12/2016 08:09, vijay.kilari@xxxxxxxxx wrote:
>> > From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
>> >
>> > Update error code returned for Invalid CPU interface register
>> > value and access in AArch32 mode.
>> >
>> > Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
>> > ---
>> > Documentation/virtual/kvm/devices/arm-vgic-v3.txt | 9 ++++++++-
>> > 1 file changed, 8 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/virtual/kvm/devices/arm-vgic-v3.txt b/Documentation/virtual/kvm/devices/arm-vgic-v3.txt
>> > index 9348b3c..0f29850 100644
>> > --- a/Documentation/virtual/kvm/devices/arm-vgic-v3.txt
>> > +++ b/Documentation/virtual/kvm/devices/arm-vgic-v3.txt
>> > @@ -142,10 +142,12 @@ Groups:
>> > KVM_DEV_ARM_VGIC_CPU_SYSREGS accesses the CPU interface registers for the
>> > CPU specified by the mpidr field.
>> >
>> > + CPU interface registers access is not implemented for AArch32 mode.
>> > + Error -ENXIO is returned when accessed in AArch32 mode.
>> > Errors:
>> > -ENXIO: Getting or setting this register is not yet supported
>> > -EBUSY: VCPU is running
>> > - -EINVAL: Invalid mpidr supplied
>> > + -EINVAL: Invalid mpidr or register value supplied
>> >
>> >
>> > KVM_DEV_ARM_VGIC_GRP_NR_IRQS
>> > @@ -193,6 +195,11 @@ Groups:
>> >
>> > Bit[n] indicates the status for interrupt vINTID + n.
>> >
>> > + Getting or setting the level info for an edge-triggered interrupt is
>> > + not guaranteed to work.
>> I don't get this statement. is the API applicable to edge triggered IRQs?
>>
>
> I guess this could be clarified to "is ignored", but with the earlier
> implementation you might be able to get away with doing
> "line_level=x; config=LEVEL;", but you could then at the same time break
> something with edge-triggered IRQs, so...
>
>
> Thanks for looking at this in detail.
>
> -Christoffer
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
