On 12/08/2016 11:05 AM, Andrew Jones wrote: > The TCG PMU is barely implemented for ARM and not at all implemented > for AArch64. Let's not bother running the TCG-only tests yet. We'll > likely move them to a new TCG-only unittests.cfg at some point before > re-enabling them too. > > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> It is always safe to disable TCG tests, as proposed in this patch. However I don't think we need it because PMU will behave correctly after your PATCH 1: 1. Under TCG AArch32 mode, get_pmu_version() returns 2. This is acceptable for pmu-tcg-icount-1 and pmu-tcg-icount-256. We should allow the tests to proceed. 2. Under TCG AArch64, get_pmu_version() returns 0. pmu-tcg-icount-1 and pmu-tcg-icount-256 will skip because pmu_probe() returns FALSE. As long as there isn't an error, most people will be OK to see SKIP message. Thanks, -Wei > --- > arm/unittests.cfg | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arm/unittests.cfg b/arm/unittests.cfg > index 044d97c9e73d..65f9c4c0b9eb 100644 > --- a/arm/unittests.cfg > +++ b/arm/unittests.cfg > @@ -65,15 +65,15 @@ file = pmu.flat > groups = pmu > > # Test PMU support (TCG) with -icount IPC=1 > -[pmu-tcg-icount-1] > -file = pmu.flat > -extra_params = -icount 0 -append '1' > -groups = pmu > -accel = tcg > +#[pmu-tcg-icount-1] > +#file = pmu.flat > +#extra_params = -icount 0 -append '1' > +#groups = pmu > +#accel = tcg > > # Test PMU support (TCG) with -icount IPC=256 > -[pmu-tcg-icount-256] > -file = pmu.flat > -extra_params = -icount 8 -append '256' > -groups = pmu > -accel = tcg > +#[pmu-tcg-icount-256] > +#file = pmu.flat > +#extra_params = -icount 8 -append '256' > +#groups = pmu > +#accel = tcg > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
