From: Shannon Zhao <shannon.zhao@xxxxxxxxxx> Commit 50926d8(KVM: arm/arm64: The GIC is dead, long live the GIC) removes the old vgic and commit 9097773(KVM: arm/arm64: vgic-new: vgic_init: implement kvm_vgic_hyp_init) doesn't reset LRs for new-vgic when probing GIC. These two patches add the missing part. BTW, here is a strange problem on Huawei D03 board when using upstream kernel that android guest with a goldfish_fb will hang with rcu_stall and interrupt timeout for goldfish_fb. We apply these patches but the problem still exists, while if we revert the commit b40c489(arm64: KVM: vgic-v3: Only wipe LRs on vcpu exit) the guest runs well. We add a trace in kvm_vgic_flush_hwstate() to print the value of compute_ap_list_depth(vcpu) and the value of vgic_lr before calling vgic_flush_lr_state(). The first output shows that the ap_list_depth is zero but the first one in vgic_lr is 10a0000000002001. I don't understand why there is a valued one in vgic_lr since the memory of vgic_lr is zero allocated. I think It should be zero when the vcpu first run and first call kvm_vgic_flush_hwstate(). qemu-system-aar-6673 [016] .... 501.969251: kvm_vgic_flush_hwstate: VCPU: 0, lits-count: 0, LR: 10a0000000002001, 0, 0, 0 I also add a trace at the end of vgic_flush_lr_state() which shows the kvm_vgic_global_state.nr_lr is 4, used_lrs is 0 and all LRs in vgic_lr are zero. qemu-system-aar-6673 [016] .... 501.969254: vgic_flush_lr_state_nuke: kvm_vgic_global_state.nr_lr is :4, irq1:0, irq2:0, irq3:0, irq4:0 But the trace at the beginning of kvm_vgic_sync_hwstate() shows the first one of vgic_lr is 10a0000000002001. qemu-system-aar-6673 [016] .... 501.969261: kvm_vgic_sync_hwstate_vgic_lr: VCPU: 0, used_lrs: 0, LR: 10a0000000002001, 0, 0, 0 The above three trace outputs are printed by the first KVM_ENTRY/EXIT of VCPU 0. Shannon Zhao (2): arm64: KVM: vgic-v3: Add the missing resetting LRs at boot time KVM: arm/arm64: vgic-v2: Add the missing resetting LRs at boot time virt/kvm/arm/vgic/vgic-v2.c | 11 +++++++++++ virt/kvm/arm/vgic/vgic-v3.c | 7 +++++++ 2 files changed, 18 insertions(+) -- 2.0.4 _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
