Hi Marc, Christoffer, Do you have any review comments on this patch set?. Regards Vijay On Fri, Sep 23, 2016 at 9:14 PM, <vijay.kilari@xxxxxxxxx> wrote: > From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx> > > This patchset adds API for saving and restoring > of VGICv3 registers to support live migration with new vgic feature. > This API definition is as per version of VGICv3 specification > http://lists.infradead.org/pipermail/linux-arm-kernel/2016-July/445611.html > > The patch 3 & 4 are picked from the Pavel's previous implementation. > http://www.spinics.net/lists/kvm/msg122040.html > > v6 => v7: > - Rename all patches heading from vgic-new to vgic > - Moved caching of priority and ID bits from vgic global struct > to vgic_cpu struct. > > v5 => v6: > - Collated all register definitions to single patch (4) > - Introduce macro to convert userspace MPIDR format to MPIDR reg format > - Check on ICC_CTLR_EL1.CBPR value is made while accessing ICC_BPR1_EL1 > - Cached ich_vtr_el2 and guests priority and ID bits > - Check on number of priority and ID bits when ICC_CTRL_EL1 write is made > - Check is made on SRE bit for ICC_SRE_EL1 write > > v4 => v5: > - ICC_CTLR_EL1 access is updated to reflect HW values > - Updated ICC reg access mask and shift macros > - Introduced patch 4 for VMCR changes > - Other minor fixes. > v3 => v4: > - Rebased to latest code base > - Moved vgic_uaccess() from vgic-mmio-v2.c to vgic-mmio.c > - Dropped macro REGISTER_DESC_WITH_BITS_PER_IRQ_SHARED_UACCESS > - Dropped LE conversion for userspace access > - Introduced vgic_uaccess_write_pending() for ISPENDR write > - Change macro KVM_DEV_ARM_VGIC_V3_CPUID_MASK to KVM_DEV_ARM_VGIC_V3_MIDR_MASK > - Refactored some code as common code. > - Changed handing of ICC_* registers > - Allowed ICC_SRE_EL1 read by userspace > - Fixed KVM_DEV_ARM_VGIC_LINE_LEVEL_INFO_* macros > > v2 => v3: > - Implemented separate API for ISPENDR and ICPENDR to > read soft_pending instead of pending for level triggerred interrupts > - Implemented ioctl KVM_DEV_ARM_VGIC_GRP_LEVEL_INFO to access line level > - Rebased on top of Christoffer's patch set > http://www.spinics.net/lists/kvm/msg136840.html > > NOTE: GICD_STATUSR and GICR_STATUSR are implemented as RAZ/WI. > > v1 => v2: > - The init sequence change patch is no more required. > Fixed in patch 2 by using static vgic_io_dev regions structure instead > of using dynamic allocation pointer. > - Updated commit message of patch 4. > - Dropped usage of union to manage 32-bit and 64-bit access in patch 1. > Used local variable for 32-bit access. > - Updated macro __ARM64_SYS_REG and ARM64_SYS_REG in > arch/arm64/include/uapi/asm/kvm.h as per qemu requirements. > > > Vijaya Kumar K (7): > arm/arm64: vgic: Implement support for userspace access > arm/arm64: vgic: Add distributor and redistributor access > arm/arm64: vgic: Introduce find_reg_by_id() > irqchip/gic-v3: Add missing system register definitions > arm/arm64: vgic: Introduce VENG0 and VENG1 fields to vmcr struct > arm/arm64: vgic: Implement VGICv3 CPU interface access > arm/arm64: vgic: Implement KVM_DEV_ARM_VGIC_GRP_LEVEL_INFO ioctl > > arch/arm64/include/uapi/asm/kvm.h | 13 ++ > arch/arm64/kvm/Makefile | 1 + > arch/arm64/kvm/sys_regs.c | 22 ++- > arch/arm64/kvm/sys_regs.h | 4 + > include/kvm/arm_vgic.h | 9 + > include/linux/irqchip/arm-gic-v3.h | 45 ++++- > virt/kvm/arm/vgic/vgic-kvm-device.c | 224 +++++++++++++++++++++++-- > virt/kvm/arm/vgic/vgic-mmio-v2.c | 57 +------ > virt/kvm/arm/vgic/vgic-mmio-v3.c | 200 ++++++++++++++++++++-- > virt/kvm/arm/vgic/vgic-mmio.c | 149 ++++++++++++++++- > virt/kvm/arm/vgic/vgic-mmio.h | 28 ++++ > virt/kvm/arm/vgic/vgic-sys-reg-v3.c | 324 ++++++++++++++++++++++++++++++++++++ > virt/kvm/arm/vgic/vgic-v3.c | 18 +- > virt/kvm/arm/vgic/vgic.h | 45 +++++ > 14 files changed, 1035 insertions(+), 104 deletions(-) > create mode 100644 virt/kvm/arm/vgic/vgic-sys-reg-v3.c > > -- > 1.9.1 > _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm