Re: [PATCH v6] KVM: arm/arm64: Route vtimer events to user space

[Alexander Graf <agraf@xxxxxxx>]

Am 23.09.2016 um 14:11 schrieb Paolo Bonzini <pbonzini@xxxxxxxxxx>:

On 23/09/2016 13:07, Alexander Graf wrote:

+        timer_ret = kvm_timer_sync_hwstate(vcpu);

       kvm_vgic_sync_hwstate(vcpu);

       preempt_enable();

       ret = handle_exit(vcpu, run, ret);

+

+        if ((ret == 1) && timer_ret) {

+            /*

+             * We have to exit straight away to ensure that we only

+             * ever notify user space once about a level change

+             */

Is this really a requirement?  It complicates the logic noticeably.

The alternative would be to track the state on ioctl entry, which Christoffer disliked :).

Alex

_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm