On Fri, Apr 01, 2016 at 01:30:40PM +0200, Christoffer Dall wrote: > On Fri, Apr 01, 2016 at 12:12:22PM +0100, Will Deacon wrote: > > The kernel is written in C, not python, so we need braces around > > multi-line if statements. GCC 6 actually warns about this, thanks to the > > fantastic new "-Wmisleading-indentation" flag: > > We should rewrite the kernel in python! Oh man, you made me look and I found this: https://mail.python.org/pipermail/python-list/2004-October/283327.html but, today's certainly the day for whacky suggestions. > > | virt/kvm/arm/pmu.c: In function ‘kvm_pmu_overflow_status’: > > | virt/kvm/arm/pmu.c:198:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] > > | reg &= vcpu_sys_reg(vcpu, PMCNTENSET_EL0); > > | ^~~ > > | arch/arm64/kvm/../../../virt/kvm/arm/pmu.c:196:2: note: ...this ‘if’ clause, but it is not > > | if ((vcpu_sys_reg(vcpu, PMCR_EL0) & ARMV8_PMU_PMCR_E)) > > | ^~ > > > > As it turns out, this particular case is harmless (we just do some &= > > operations with 0), but worth fixing nonetheless. > > > > Signed-off-by: Will Deacon <will.deacon@xxxxxxx> > > Thanks for the patch. No problem. I timed it nicely with your pull request. Will _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
