On Mon, Mar 21, 2016 at 01:36:10PM +0100, Paolo Bonzini wrote: > > > On 21/03/2016 09:47, Ard Biesheuvel wrote: > > On 18 March 2016 at 18:25, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > >> When running with VHE, there is no need to translate kernel pointers > >> to the EL2 memory space, since we're already there (and we have a much > >> saner memory map to start with). > >> > >> Unfortunately, kvm_ksym_ref is getting in the way, and the first > >> call into the "hypervisor" section is going to end up in fireworks, > >> since we're now branching into nowhereland. Meh. > >> > >> A potential solution is to test if VHE is engaged or not, and only > >> perform the translation in the negative case. With this in place, > >> VHE is able to run again. > >> > >> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx> > > > > I think you need the & when initializing val, otherwise, it will > > silently refer to the value rather than the address of a void* symbol > > if we ever end up using this macro on one. > > > > That was the whoie point of the opaque struct type in the original > > patch that introduced this macro, to disallow references lacking the > > &, but unfortunately, that was incompatible with the other VHE > > changes. > > > > With that fixed > > > > Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > Marc, if you send a v2 I can merge it directly without a pull request. > Marc is on holiday this week, but I put this (with the fix) on top of Linus' master in the kvmarm/master branch: git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git master Do you want to just grab it from there? Thanks, -Christoffer _______________________________________________ kvmarm mailing list kvmarm@xxxxxxxxxxxxxxxxxxxxx https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
