On Thu, Feb 04, 2016 at 01:18:38PM +0100, Alexander Gordeev wrote:
> On Fri, Jan 15, 2016 at 04:32:11PM +0100, Andrew Jones wrote:
> > > +struct pci_testdev_ops {
> > > + u8 (*read8)(const volatile void *addr);
> > > + u16 (*read16)(const volatile void *addr);
> > > + u32 (*read32)(const volatile void *addr);
> > > + void (*write8)(u8 value, volatile void *addr);
> > > + void (*write16)(u16 value, volatile void *addr);
> > > + void (*write32)(u32 value, volatile void *addr);
> >
> > Please use the standard 'b', 'w', 'l' in these names.
>
> I did not use in the first place as it conflicts with standard
> read*/write* macros. Would [read|write]_[byte|word|long] work
> for you?
Oh yeah... dang macros. _byte/word/dword like the pci_config_read/write
function in Linux would work.
drew
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
