On Thu, Mar 26, 2015 at 10:19:55PM +0000, Marc Zyngier wrote:
> On Thu, 26 Mar 2015 22:03:23 +0000
> Will Deacon <will.deacon@xxxxxxx> wrote:
> > On Thu, Mar 19, 2015 at 01:59:33PM +0000, Marc Zyngier wrote:
> > > + for (i = 0; i < alt->alt_len; i += sizeof(insn)) {
> > > + insn = get_alt_insn(origptr + i, replptr + i);
> > > + *(u32 *)(origptr + i) = insn;
> >
> > My brain's not firing on all cylinders right now, but do you need a
> > cpu_to_le32 here?
>
> I'm not 100% awake myself (probably some acute form of firmwaritis),
> but I suspect you're quite right (get_alt_insn calls aarch64_insn_read,
> which does a le32_to_cpu). Obviously, we need to revert the conversion
> when writing the instruction back.
>
> Do you want a fixup on top of this, or would you prefer me to respin
> the series?
Please respin and add my acks.
Will
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
